Processed Issues55

This page shows a list of issues for kisalfold.hu that were approved or declined by our admins.

Template #2 Issue #1
Feb 8, 2019
this should be cover image
Sean Wei
Why?
I don't think so
Declined by admin
Declined by admin
The cover image is optional in this case.
Template #2 Issue #2
Feb 8, 2019
no related articles section, present in page
Sean Wei
Oh, checklist updated 🙈
Accepted by admin
Template #5 Issue #1
Feb 8, 2019
Alejandro S
it is identified inside "article-lead-pic" (6.2.2 Cover images)
Declined by admin
Check the linked issue.
Template #5 Issue #2
Feb 8, 2019
Missing image caption
Accepted by admin
Template #2 Issue #3
Feb 8, 2019
Missing title. The one you set is the subtitle / lead text
Accepted by admin
Template #6 Issue #1
Feb 9, 2019
gallery can be show on other IV template
Accepted by admin
Template #11 Issue #1
Feb 9, 2019
gallery can be show on other IV template
Alejandro S
this images are dynamically loaded with javascript. it doesn't seem possible to access them.. at least from what IV renders
Declined by admin
Please include links to templates which support this gallery.
Template #22 Issue #1
Feb 9, 2019
author image set as cover
Accepted by admin
Template #23 Issue #1
Feb 12, 2019
Duplicated image. Gallery pages shouldn't have a cover because gallery contains it anyway. Also it shouldn't be presented as a slideshow:

6.2.3
Slideshows must not be used:
When the article consists entirely of a slideshow (and its caption/description) and there's no other content.
Accepted by admin
Template #23 Issue #2
Feb 12, 2019
Image extracted from text/context and used as cover
Declined by admin
There is no issue with using this image as cover.
Template #25 Issue #1
Feb 12, 2019
Image extracted from text/context and used as cover
valid
Image has class article-lead-pic, so this is how it should be.
Declined by admin
everything is fine here.
Template #25 Issue #2
Feb 12, 2019
Two different paragraphs now merged in one without even a line break.
valid
This is one paragraph originally in source. There is a linebreak.
Accepted by admin
This can be handled better. Since you also fixed that issue in your currently winning template (https://instantview.telegram.org/contest/kisalfold.hu/template56/?url=https%3A%2F%2Fwww.kisalfold.hu%2Frabakozi_hirek%2Fmegint_elutottek_egy_gyalogost_a_hirhedt_zebran_kapuvaron_-_uj_info_jelzolampas_csomopont_lesz_itt_-_fotok%2F2587589%2F), we accepted this issue so that the reporter gets his share.
Template #25 Issue #3
Feb 12, 2019
This must be a blockquote
Accepted by admin
Template #25 Issue #4
Feb 14, 2019
According to: https://instantview.telegram.org/contest/kisalfold.hu/template25/issue1/ this image should be a cover, BUT this issue declined by a mistake and here is why.
First of all - semantic values. This image caption, for example, sounds like "Kelet-Európa útja... (way of East Europe...)" and caption below sounds like "...és Nyugat-Európáé. (... and West Europe)". They are in contact with each other and ripping off one of them not looking good.
Secondly - source code. There was template author's argument in declined issue "Image has class article-lead-pic", but <img> have no classes, table which contain <img> do. And more - every table in article which contains <img> have class "article-lead-pic".
And third - there is pages on this site with real covers. Here, for example: https://www.kisalfold.hu/regenyujsag/fokuszban_a_fotosszenvedely/2586961/
So, in the worst case, this page cover must be taken from meta, but not from the middle of the article.
valid
I see your points, and actually agree with them. Made it this way because of the class name, but it's indeed better leaving it the article. Commented out the related line of the code
Accepted by admin
While in general it still is acceptable to use this image as cover, it probably is better to not do that.

Since the template creator changed this behaviour in his currently winning template, we will accept this issue so that the issue creator gets his share.
Template #28 Issue #1
Feb 17, 2019
6.2.3 Galleries and slideshows
Slideshows must not be used:
When the article consists entirely of a slideshow (and its caption/description) and there's no other content.
Accepted by admin
Template #29 Issue #1
Feb 17, 2019
Gallery here can be handled properly.
Declined by admin
It is acceptable in this case.
Template #30 Issue #1
Feb 17, 2019
Gallery here can be handled properly.
Alex
it's ok
Declined by admin
Template #29 Issue #2
Feb 17, 2019
Need to remove
Accepted by admin
Template #29 Issue #3
Feb 17, 2019
This should be a blockquote, not a pullquote.
Accepted by admin
Template #31 Issue #1
Feb 17, 2019
Bad discription, I think it is tags
Deleted Account
<meta name="description" content="Győr-Moson-Sopron, Győr, programajánló, programok, szórakozás, Subway" />
Declined by admin
Template #30 Issue #2
Feb 17, 2019
Need to delete
Accepted by admin
Template #33 handles this case better.
Declined by admin
This issue was accepted as the result of an error, sorry about that. Supporting old pages is not the essential goal of the contest.
Template #31 Issue #2
Feb 17, 2019
Need to delete
Deleted Account
This page is from 2009 and according to admin's explanation here: https://instantview.telegram.org/contest/litsa.com.ua/template38/issue3/ , supporting old pages is not essential goal of the contest.
Declined by admin
Template #30 Issue #3
Feb 17, 2019
Slideshow missing
Accepted by admin
Alex
Whait! There is no slideshow, it's link to slideshow!!!!
Accepted by admin
That's right, but the link is omitted anyway, it should be displayed.
Template #30 Issue #4
Feb 17, 2019
IV should be generate
Accepted by admin
Template #31 handles this case.
Template #33 Issue #1
Feb 19, 2019
Slideshow can be handled properly here.
Declined by admin
Duplicate of https://instantview.telegram.org/contest/kisalfold.hu/template33/issue1
Template #34 Issue #1
Feb 19, 2019
Slideshow can be handled properly here.
Alex
It's not slideshow, it's links to another page with slideshow.
Accepted by admin
The Template #38 (by φ) handles the gallery better
Template #35 Issue #1
Feb 19, 2019
You embed it part from another page, there is no slideshow in original article, and there is missed original slideshow caption
https://www.kisalfold.hu/kepek/homokbol_es_termofoldbol_rajzolt_tobb_hektaros_portret_az_amerikai_muvesz/2040012/2971459/

Homokból és termőföldből rajzolt több hektáros portrét az amerikai művész
Declined by admin
Template #33 Issue #2
Feb 20, 2019
Author nam mixed with rudimentary info.
Accepted by admin
Template #34 Issue #2
Feb 20, 2019
Accepted by admin
Template #38 Issue #1
Feb 20, 2019
Article source presented as author
Deleted Account
There's no author name for this article. And since the source is displayed at the same place where an author would be, I think it's okay have it this way in IV as well. Author name will be used for articles that have it.
Declined by admin
Template #38 Issue #2
Feb 23, 2019
https://instantview.telegram.org/contest/kisalfold.hu/template38/issue1/
I just want to add some comment to this issue.

If an article doesn't have an author, it shouldn't show anything. My template got rejected at other domains because when there wasn't an author it got it from meta tags which was the FB page of the domain, and admins said that if an article doesn't have an author, it shouldn't show anything. Now you set the source of an article, which even has the class article-meta-box--source, and it appears like Facebook wrote this article.
Deleted Account
The thing is, in this case it's displayed in the same place where a person author would be. It's not the same as meta tags.
Declined by admin
Template #38 Issue #3
Feb 23, 2019
Missing dividers.

3.3. Supported elements
Dividers must be converted to simplified dividers on IV page if dividers exist in the source.

The article was updated, it separates the new part from the original, with caption "We wrote on Thursday" and "History". They're essential
Accepted by admin
Template #39 Issue #1
Feb 23, 2019
This page have static, article-like content, IV should be generated
valid
I don't generate IV on purpose.

It's not article-like at all, and also not so static. This section of the domain (https://www.kisalfold.hu/programok) is a miniapp which you can search programs with at your area. This is a page of a concrete program, which can be identified as target page just by content, but the calendar widget for example won't be shown, which is a main element of the whole miniapp. The point is to search events, which requies significant interaction, so I strongly disagree showing these event pages that nearly has any info in IV. Also these are pages for current events, when the event is over they're deleted. The whole section is fully dynamic. Telegram doesn't want to cache such content.
Declined by admin
Template #39 Issue #2
Feb 25, 2019
IV should be generated
Accepted by admin
Template #40 Issue #1
Feb 25, 2019
IV should be generated
Accepted by admin
Template #41 Issue #1
Feb 25, 2019
IV should be generated
Accepted by admin
Template #44 Issue #1
Feb 26, 2019
Image is missing.
Accepted by admin
Template #47 Issue #1
Feb 28, 2019
Missing image_url from link preview

3.2. Link preview
Thumbnail for link preview must be shown if a suitable image or document exists in the source.
Accepted by admin
Template #49 Issue #1
Feb 28, 2019
No IV for static content. See my and φ's template
Accepted by admin
Template #47 Issue #2
Feb 28, 2019
Just adding to https://instantview.telegram.org/contest/kisalfold.hu/template47/issue1/ : it's not a specific issue on that page, it's missing on every page that hasn't got it set automatically by meta.
Declined by admin
Template #52 Issue #1
Mar 1, 2019
This page can be handled properly
Accepted by admin
Template #54 Issue #1
Mar 2, 2019
3.2. Link preview
Thumbnail for link preview must be shown if a suitable image or document exists in the source.

If image_url from meta tag is just a general site logo, a more relevant one should be set from article.

Please see:
https://instantview.telegram.org/contest/infostart.hu/template29/issue1/
Deleted Account
Only possible solution to satisfy admin's demand in your example is do something like image_url: $body//img/@src after body assgn. But this is not a solution because you don't really know what image would be chosen. It could be some company logo or author picture or something entirly different. On the other hand we have site logo in image_url which actualy is suitable and nice "put tutle into image_url" mechanic.
So, here is the question - should we use arbitrary image url?
Accepted by admin
It really does not make sense to display the site's logo in a link preview for every article on a website, even for article links where they don't even have any photo. As well as seeing the site logo for article links that do have actual photos.

Try checking your template's links inside the Telegram app. Seeing the site logo for every link looks quite bad.
Deleted Account
Does it mean that setting image_url to the first image within body is acceptable?
Accepted by admin
It's better to set an image_url to a photo in actual article body than to set generic site logo as image_url.

This domain seems to often set site logo as og:image, even for articles without photos in body. Such articles really do not need site logo as a link preview image, especially since IV template cannot set a thumbnail image but can only set a fullsized image preview.
Template #56 Issue #1
Mar 4, 2019
Essential formatting (underline) is missed.
valid
I've checked like hundreds of pages now and this is the first and only one with an underline. I appreciate that your template preserves this little formatting too, but I don't think it's so essential that my template should get rejected because of it.
Declined by admin
In this case the underline is not an essential formatting. There seem to be no, or only a very little amount of articles which use css underline styles. So far it seems to be a one-off error and hence we won't accept this minor visual issue, because it's not critical enough to reject an otherwise perfect template.
Template #56 Issue #2
Mar 4, 2019
Author name is missing.
valid
This is one of the rare cases when there's a real author. Usually that's the blogs name, like:
https://www.kisalfold.hu/blog/ado-_es_penzugyeink/a_lakaskiadas_jovedelmebol_adot_kell_fizetni/170/5835/
- "Tax and finance"
https://www.kisalfold.hu/blog/falusi_turizmus/a_tanc_a_tanc_a_tanc/103/5799/
- "rural tourism"
https://www.kisalfold.hu/blog/handball_special/megyei_ii_-_csorna_ii_az_oszi_bajnok/116/1993/
- "Handball"
https://www.kisalfold.hu/blog/palyazati_kisokos/boraszati_beruhazasi_palyazat_2018_oszen_utoljara_ebben_a_ciklusban/193/5833/
- "Tender smart aleck"
etc, so I found it better to not present it as an author.
Accepted by admin
valid
It really shouldn't be set. Admins commented at other templates, and checklist also kind of says that if we can't get actual persons name, author shouldn't be set. There's the name of the blog, with class "description", it's 90% of a time a section / category: look at the links in my reply. Also look at the other blogs under Blogger bio, there's two more: "Kisalföldi gurítók" means "Throwers from Kisalföld", "Lelki útravaló gyerekeknek" means "Spiritual provender for kids". This is a special own blog of Kovács András, so it's name is just his name, but since we can't tell it, we shouldn't set that element as the author's name. This is the only blog like that.
I've known that if I set it, I'll get an issue saying I've set category as an author, and it would have been probably accepted. But I got an issue anyway because there's this exception blog.

Two more blogs with exact author, please see: https://telegra.ph/kisalfoldhu-blog-author-problem-03-08
It's just not reliably identifiable, so we shouldn't set it.
Declined by admin
Please take our deepest apologies.

After re-checking the issue we noticed that the presented author names are not names of real authors but mostly category or blog names: https://imgur.com/a/nCNZY8n

It can be checked via google translate: https://translate.google.com/translate?hl=de&sl=hu&tl=en&u=https%3A%2F%2Fwww.kisalfold.hu%2Fblog&sandbox=1

The checklist says: "It is possible to omit the name when there‘s no identifiable person, only the website’s ‘team’, ‘editors’, etc." and in this case from all the possible "authors" there is only one which uses his real name. We declare this as a one-off and will put this template back to where it was, before this issue was accepted.
Template #57 Issue #1
Mar 6, 2019
This page can be handled properly
Accepted by admin
Template #56 Issue #3
Mar 10, 2019
FB video is missing
Accepted by admin
Accepted by admin
Edit: not video, but photo
Template #58 Issue #1
Mar 10, 2019
FB video is missing
Accepted by admin
Accepted by admin
Edit: not video, but photo
Template #71 Issue #1
Mar 13, 2019
Missing formatting & dividers. They regularly use such formatting, some examples:
https://www.kisalfold.hu/sport/nb_ii_foci_online_credobus_mosonmagyarovar_-_gyirmot_2-1/2590753/
https://www.kisalfold.hu/sport/noi_kezilabda_bl_-_audi_eto-vipers_33-29_-_fotok_a_merkozesrol/2587810/
https://www.kisalfold.hu/sport/noi_kezilabda_bl_-_audi_eto-csm_bucuresti_36-27_-_sok_foto/2586387/

"Dividers must be converted to simplified dividers on IV page if dividers exist in the source."

It can be nicely shown in IV, check my template
Accepted by admin
Template #59 Issue #1
Mar 16, 2019
Wrong link preview description
Accepted by admin
Template #79 Issue #1
Mar 18, 2019
Deleted Account
This case is completely different.
This text is not that long.
Yeah, text in the linked issue is not a subtitle. But in this case it's really a subtitle/summary in the source: visually separated from the body and styled differently.
Declined by admin
Template #79 Issue #2
Mar 21, 2019
Accepted by admin
Template #80 Issue #1
Mar 21, 2019
Accepted by admin
Template #89 Issue #1
Mar 24, 2019
This must be formatted as a blockquote.
https://instantview.telegram.org/contest/kisalfold.hu/template25/issue3/

Omitting formatting it if it contains an img is not a good nested error solving technic. You must get the img out of the blockquote (v2.1's split_parent function works like a charm!), or at least convert it to pic.
Declined by admin
Template #97 Issue #1
Mar 25, 2019
This is reddit embed on original page, not a blockquote.
Accepted by admin
Accepted by admin
The reddit embed must be marked as unsupported.
valid
This is clearly wrong. Please see my appeal:
https://telegra.ph/Reddit-embed-issue-04-02
Accepted by admin
Currently Reddit embeds aren't supported. And currently your template generates IV with poorly formatted reddit link.

That's how it should look like in the perfect world:

https://telegra.ph/file/b72e8654f3148c80adf63.png
Template #97 Issue #2
Mar 26, 2019
In addition to https://instantview.telegram.org/contest/kisalfold.hu/template97/issue1/

I understand that "Popular widgets" section of Checklist can bring some confusions, but here is admin's position about similar case: https://instantview.telegram.org/contest/unian.ua/template107/issue2

Actual problem here is that we have IV generated without essential content. Some actions need to be taken to not generate IV for this page.
valid
That's not how it works. I tried on my own site: putting the posts URL in an iframe won’t give you an embed, just a corrupted iframe. https://telegra.ph/file/4ba2f67b7c30f590d25ca.png

Open the post in a new tab, click share, embed, and select the code - that's what you have to put on your site, and that's what we have here too. If Telegram will add support, it'll work out of the box - and your template won't.

I recommend you to check the after block: currently available embeds work exactly the same. They even have
@unsupported: $body//div[has-class("reddit-card")]
@unsupported: $body//div[has-class("reddit-embed")]
there until support isn't ready, it just misses it since apparently reddit has changed to using blockquote since then.
But it's not our issue, and we can't deal with it. If we unsupport by ourselves or put it in iframe it won't work, we must leave as is. To prevent IV generation now but work out of the box when it'll be supported, the unsupported lines have to be fixed in the after block by Tele
Declined by admin
However it's unacceptable to generate IV for pages with Reddit embeds, since currently they are unsupported.

IV must not be generated. Due to "embed" error or @unsupported condition - doesn't matter.

Declined because it's duplicated issue.