Preview
Issue #3
- Rodrigo Vieira
- I'm not going to do it, because your solution is not safe. You pretty much did a replacement on almost the entire URL and still converted an iframe to a video.
In the future Telegram can support Gifs from Gfycat and make it more consistent and stable than yours solution.
Who guarantees me that this will always work:
before: "https://gfycat.com/ifr/CandidSpicyJabiru"
$gfycat: $body//iframe[contains(@src, "gfycat.com")]
@replace("gfycat.com/ifr/", "giant.gfycat.com/"): $gfycat/@src
@set_attr(src, @src, "\\.mp4"): $gfycat
<video>
after: "https://giant.gfycat.com/CandidSpicyJabiru.mp4"
If in the future the Telegram starts to support Gfycat, these gifs will work.
In your template, if Gfycat only deactivates the ".giant" subdomain or replace it with another, your template will stop working for something that can be supported by the IV in the future.
I will await for the admin decision.
I'll risk losing this template.
- Declined by admin
- Type of issue
- IV not generated for target page
- Reported
- Mar 13, 2019
gfycat video could be supported using direct link to mp4.