Processed Issues41

This page shows a list of issues for rog.asus.com that were approved or declined by our admins.

Template #2 Issue #1
May 27, 2017
Interactive search page, IV should not be generated.
Accepted by admin
This page must not generate an IV in accordance to 2.1 of Perfect Template Checklist:
https://instantview.telegram.org/checklist#2-iv-targets-must-not-generate
Template #3 Issue #1
Jun 8, 2017
The page contains a complex unsupported table.
This page should not be generated.
Accepted by admin
Template #6 Issue #1
Jun 9, 2017
There should be 4 slides
Accepted by admin
Template #21 Issue #1
Jun 10, 2017
A page with a complex table should not be generated
Accepted by admin
Here is a better one:

https://instantview.telegram.org/contest/rog.asus.com/template44/?url=https%3A%2F%2Frog.asus.com%2Farticles%2Foverclocking%2Fwhat-does-it-takes-to-reach-the-best-intel-core-cpu-frequency-at-7328-mhz
Template #48 Issue #2
Jun 19, 2017
Dynamic page with news
Алексей
fixed
Accepted by admin
Template #49 Issue #2
Jun 19, 2017
There should be 3 different images
Accepted by admin
Here is a better one:

https://instantview.telegram.org/contest/rog.asus.com/template48/?url=https%3A%2F%2Frog.asus.com%2Fes%2F72412015%2Fnews%2Fasus-turbo-geforce-gtx-960
Template #50 Issue #1
Feb 4, 2019
Tags are not included
Declined by admin
Template #50 Issue #2
Feb 4, 2019
tags and related articles are missing
Declined by admin
Declined by admin
Template #50 Issue #3
Feb 4, 2019
no instantview
Declined by admin
Template #50 Issue #4
Feb 4, 2019
instantview not showing
Declined by admin
Template #50 Issue #5
Feb 5, 2019
ELEMENT_NOT_SUPPORTED
Accepted by admin
It seems possible to support the content of this article, as with Alex's template.
Template #52 Issue #1
Feb 5, 2019
Empty paragraphs can be removed
Denis
It's pretty matches with original article and removing doesn't add anything to readability or overall view
Declined by admin
Template #52 Issue #2
Feb 5, 2019
No Instant View available
Denis
Link is broken and leads to home page
Declined by admin
Template #52 Issue #3
Feb 5, 2019
This is related to press release button. It should be removed or make <details>
Accepted by admin
Yes, this text does not make sense in the IV.
Template #54 Issue #1
Feb 5, 2019
missed image
Declined by admin
I'm not sure what the missed image is supposed to be. They seem to be in the IV? Maybe the issue can be clarified?
Template #61 Issue #1
Feb 6, 2019
Accepted by admin
The name of the website is incorrect. Template #62 properly handles this case.
Template #71 Issue #1
Feb 12, 2019
Should have IV
Accepted by admin
Template #77 Issue #1
Feb 13, 2019
Static page. Needs IV
Fran Košec
These are random non-indexed, non-categorised pages, not articles. They've been abandoned for several years now.
Accepted by admin
Template #80 Issue #1
Feb 13, 2019
It's a static page. Should be IV
Fran Košec
You're taking it too far and don't understand what this is all about. The point of IV isn't to target every single existing static page (there are hundreds of them only on rog.asus.com as there are on other sites, so we can continue doing this manually for months). The point is to target pages that present the majority of real content (predominately articles, galleries, documentation...). I would love to hear what the Telegram staff/admin has to say about this. I indulged your requests to parse the /technology/ part of the website even though it's deprecated/abandoned, because there was some value in it. There is no value in parsing /about pages and stuff like this.
Declined by admin
Template #80 Issue #2
Feb 13, 2019
It's a caption to the slideshow. It can be identified as other captions on this page.
Accepted by admin
Template #85 Issue #1
Feb 15, 2019
No Instant View available
Accepted by admin
Template #90 Issue #1
Feb 16, 2019
IV page should use better quality images
Accepted by admin
Template #93 Issue #1
Feb 16, 2019
Should have IV
Fran Košec
True, but it's a YouTube iframe inside a div inside a link <a>. Who in their right mind would put a YouTube iframe inside <a>...
Accepted by admin
Template #100 Issue #2
Feb 17, 2019
Missing site_name
Accepted by admin
The site_name property must include the correct name of the website
Template #99 Issue #1
Feb 17, 2019
Dividers must be converted to simplified dividers on IV page if dividers exist in the source.
Fran Košec
Since this is a duplicate issue - the answer is in:
https://instantview.telegram.org/contest/rog.asus.com/template99/issue2/
Declined by admin
duplicate issue
Template #99 Issue #2
Feb 17, 2019
Duplicate issue.

Dividers (###) in details block at the end of the page (can be open by clicking with holding ctrl) must be converted to simplified dividers on IV page if dividers exist in the source.
Fran Košec
I believe this is reaching for a problem that is not there and as such doesn't need solving.

If this were a divider, it would have been converted to a simplified divider, however this is just a centered paragraph consisting of just three hashes: <p align="center">###</p>.

Nothing of value is being lost or being added, Telegram's IV can cope with a paragraph (meaning, it's not a complicated element that needs transforming), and we can't just assume this is a divider.
Declined by admin
it's just text in a <p> tag, so it can't really be detected reliably
Template #99 Issue #3
Feb 19, 2019
It's image captions
Fran Košec
Kind of a stretch - wouldn't say so, but I'll do it.
Accepted by admin
Template #99 Issue #4
Feb 19, 2019
These social media links aren't for sharing, it's essential to article and can be formatted as in the original article.
Fran Košec
Wouldn't say it's absolutely essential to format them one after other, but I'll do it anyway. They keep their link, so they are correctly parsed.
Accepted by admin
Template #111 Issue #1
Feb 19, 2019
There are empty captions
You can see a shadow on the image
Fran Košec
Actually, original images contain captions, however authors of the article chose to write blank spaces in some of them (can be seen that the article/images contain "<div class="gallery-caption">"). I have not added my own captions/content. The IV is the same as the article - I chose not to remove certain things that are not mandated to be removed, to keep the original article as it is in IV, as well. There are no rules that say we have to remove empty captions/paragraphs/headers (sometimes websites use them as separators) - that can and should be done in "...after", if needed.
Declined by admin
Template #111 Issue #2
Feb 21, 2019
Static-article page
Fran Košec
It's a non-indexed page, never linked anywhere on the site, and not a news publication but OK, if you say so...
Declined by admin
Template #106 Issue #4
Feb 21, 2019
Duplicate title
Accepted by admin
Template #111 Issue #3
Feb 21, 2019
There is no date on the page like that.
This date can be confusing to the user because it either matches the date in the header or is in the range.
Fran Košec
Checklist
6.1.2 Date and time
The date and time of publication is obligatory for news publications. It must be obtained by any means possible, including meta tags, etc.

This is a news publication regarding a promotion.
Both the date of publishing and date of modification are present in the source/JSON that is attached to every news publication/article on this site, and therefore is parseable and is obligatory to be added to IV - it must be obtained by any means possible.
Declined by admin
Template #113 Issue #1
Feb 21, 2019
This is a caption and should be parsed as such (check my IV).
Алексей
Ohh stop it.
All the captions on this website added manually.
This case is not suited in my template just because the mad author of the article decided to add <p> </p> after image and next is simple <p><em></em></p>

There is no container, there is no class to detect captions...

Let me explain.
I think you removed <p> </p>, right? And then took the next paragraph after image as a caption.
What if there will be several empty p? What if cursive text after <p> </p> will be not related to image?

Look on our issues, most of them are "missing captions", I'm tired of finding them.
Declined by admin
Template #113 Issue #2
Feb 21, 2019
Duplicated - to clarify further, why this is an issue of missing captions.

Most of the captions on this site are in <p><em>caption</em></p> with no additional text only in <p>, after an image or a YouTube video.

Submitter's IV template checks for caption after images, but not after YouTube videos.
Алексей
The answer is here https://instantview.telegram.org/contest/rog.asus.com/template113/issue1/

Addition:
I handle most popular cases, for example on this page video have a caption
https://rog.asus.com/articles/gaming/inside-croteam-the-game-studio-going-all-in-on-virtual-reality/


I want to say that the author can add whatever he wants:
empty paragraph, empty heading, <br> tag, etc. we can endlessly check all pages in search of such cases
Admin, please finish this.
Declined by admin
Template #113 Issue #3
Feb 22, 2019
Site name in Link Preview is totally wrong, it's just the title of the page.

The site_name property must include the correct name of the website. If the webmaster includes unnecessary data (e.g. ‘Site {sitename}’) or mixes the site name with the article title, your template must take care of this.


Alex first asks us to support all these random non-article pages, reports tiny mistakes, and then whines when the same issues are reported on his IVs, when he does it wrong. Last time I checked, this contest is about making a perfect template. Alex, if you're tired of finding mistakes, give up... I checked all the issues from 2017. to today - you reported the same things you whine about now. Make a good template and no one will be able to report any issues - that's what I'm trying to do.
Алексей
Look
<meta property="og:site_name" content="Devenez joueur pro grâce à la ROG SCHOOL !">

There is no sitename here.
There are few such pages where there is no possibility to get the site name.
Add manually?
Accepted by admin
The site_name property must include the correct name of the website. If the webmaster includes unnecessary data (e.g. ‘Site {sitename}’) or mixes the site name with the article title, your template must take care of this.
Template #115 Issue #1
Feb 22, 2019
Should be inside gallery
Fran Košec
Slideshows are required only if the source article shows several photos or other media as a slideshow or gallery.
If there are several ordinary images/videos/GIFs following each other in the source, you may also convert them into a slideshow, but this is purely optional.
We will not accept issues based on presence or absence of slideshows for ordinary images following each other in the source article.


I intentionally chose not to combine them, to keep them as they appear in the original article. Every element with the class or designation "gallery" is converted to a slideshow, but any additional separate images before or after the gallery don't need to be appended to the slideshow.
Declined by admin
Template #115 Issue #2
Feb 22, 2019
There is no date on the page
Fran Košec
Checklist
6.1.2 Date and time
The date and time of publication is obligatory for news publications. It must be obtained by any means possible, including meta tags, etc.

This is a news publication regarding a promotion.
Both the date of publishing and date of modification are present in the source/JSON that is attached to every news publication/article on this site, and therefore is parseable and is obligatory to be added to IV - it must be obtained by any means possible.
Declined by admin
Template #115 Issue #3
Feb 24, 2019
There is only one author.
Andrew Rainni added manually and it's not safe to take the last paragraph starts with "By"
Fran Košec
I have checked multiple hundreds of articles and have implemented a bit more complex set of rules by which I pick the author. I have not found an article where wrong information is passed into the author property.

Moreover, this is safe, because they stopped doing this in newer articles.

It wouldn't be OK to just discard "ROG" or other info that appears in the first "written by" tag because it's still relevant (I can't predict what they'll write there, be it ROG or something else), but a real author's name should be there as well, when it's available.
Declined by admin
Template #115 Issue #4
Feb 25, 2019
Why this page generate https://rog.asus.com/about-rog/
and this one not? They are the same except language

P.S
You are lucky with Arbiter who checks your template and declined last issues
Fran Košec
This is an "about us" service part of the webpage and presenting it in IV it is fully optional. It contains different formatting than all the regular articles, so it's not parsed.

Please read up on the checklist.
Declined by admin
Template #115 Issue #5
Feb 25, 2019
I will create this issue again, maybe you didn’t understand what I’m talking about

I mean double "By"

Another page didn't have this issue https://rog.asus.com/articles/campaigns/what-it-takes-to-win-a-grand-final/

There is only one author, either ROG as a whole, or an author named
Fran Košec
Refer to
https://instantview.telegram.org/contest/rog.asus.com/template115/issue3/

If there's a real author in the article, we should present it as well.
Accepted by admin
Template #123 Issue #1
Feb 27, 2019
Rudimentary content not removed
Fran Košec
We can't just remove paragraphs and content on a whim.

This serves a purpose - instructs the reader what's appended to the article, in terms of a press release, and what the reader can expect when expanding the details tag. It's exactly what you find in the original article and should not be removed.
Declined by admin