Processed Issues34

This page shows a list of issues for bladi.net that were approved or declined by our admins.

Template #1 Issue #1
Jun 9, 2017
Title is corrupted
Accepted by admin
Template #2 Issue #1
Jun 9, 2017
Few paragraphs are missing
Accepted by admin
Template #4 Issue #1
Jun 9, 2017
cover caption is missing
Accepted by admin
Template #7 Issue #1
Jun 9, 2017
Weather forecast pages shouldn't be generated.
Accepted by admin
Template #6 Issue #1
Jun 9, 2017
No line break after the lead paragraph.
Accepted by admin
Template #8 Issue #1
Jun 9, 2017
Time is different.
Why did you used offset +02?
Morocco in GMT zone.
Accepted by admin
Template #9 Issue #1
Jun 9, 2017
No line break after the lead paragraph.
Accepted by admin
Template #6 Issue #2
Jun 9, 2017
Should be a list.
Declined by admin
Template #11 Issue #1
Jun 9, 2017
Should be a list.
Declined by admin
Template #12 Issue #1
Jun 9, 2017
Missing newline
Declined by admin
Not critical.
Template #11 Issue #2
Jun 9, 2017
Missing and misaligned header.
Accepted by admin
Template #15 Issue #1
Jun 9, 2017
Missing header.
Accepted by admin
Template #16 Issue #1
Jun 9, 2017
missing list items
Dmitry
This is a meta-information. They are moved to published_date and author accordingly.
Declined by admin
Template #16 Issue #2
Jun 9, 2017
Caption missed
Accepted by admin
Template #17 Issue #1
Jun 9, 2017
Caption missed
Accepted by admin
Template #21 Issue #1
Jun 10, 2017
Wrong positioning.
Accepted by admin
Template #18 Issue #1
Jun 10, 2017
Accepted by admin
Template #21 Issue #2
Jun 10, 2017
Accepted by admin
Template #18 Issue #2
Jun 10, 2017
Icon lack of caption. Mispositioned icon.

Basically it is the same markup as in
https://instantview.telegram.org/contest/bladi.net/template16/issue2/
Accepted by admin
Template #21 Issue #3
Jun 10, 2017
Icon lack of caption. Mispositioned icon.

Basically it is the same markup as in
https://instantview.telegram.org/contest/bladi.net/template16/issue2/
Accepted by admin
Template #23 Issue #1
Jun 14, 2017
Missing date
Accepted by admin
Template #25 Issue #1
Jun 14, 2017
missing date
Accepted by admin
Template #26 Issue #1
Jun 14, 2017
Accepted by admin
Template #28 Issue #1
Jun 14, 2017
Accepted by admin
Template #29 Issue #1
Jun 14, 2017
Subheaders are lost inside the list.
Dmitry
Actually they are not a sub-headers.
They are simple paragraphs (<p> tag without any classes,styles or ids) inside a list element (<li>).
They are looking a bit enlarged because of font-size defined in "em" units and "em" is relative to parent.
.article p, .article li { font-size: 1.15em; }

Either it was a redactor mistake or done intentionally - we definitely should not just extract all <p> elements from the <li>. Side effects on other pages will be expected.

Right now there is no content loss or added content.
Declined by admin
The template creator makes a good point. The structure of this page's HTML and CSS is quite strange. It's difficult to tell if the original page was implemented this way by accident or on purpose. It's definitely not a standard way to show subheaders.

Since this seems like a one-off formatting case, supporting this is optional.
Template #29 Issue #2
Jun 14, 2017
IV not generated
Dmitry
This a AMP-page.
https://www.ampproject.org/
So this is kind of IV for mobiles made by Google.
There is no direct link from origin site leading to this page.
Declined by admin
Supporting AMP is optional.
Template #30 Issue #1
Jun 14, 2017
IV not generated
Accepted by admin
Template #29 Issue #3
Jun 15, 2017
This page could be supported, see: https://bladi.net/jours-feries-au-maroc.html
Dmitry
While 2-column tables may be supported in your template it looks confusing and ugly:
"Jours f矇ri矇s au Maroc: Date" (translation: "Holidays in Morocco: Date")
Declined by admin
Template #34 Issue #1
Jun 15, 2017
This page could be supported, see: https://bladi.net/jours-feries-au-maroc.html
Accepted by admin
Template #29 Issue #4
Jun 18, 2017
This page is static and must be generated, see my template.
Dmitry
Three-column tables and more complex tables should be tagged as @unsupported.
https://instantview.telegram.org/checklist#6-8-1-tables
Declined by admin
Support for complex tables is optional.
Template #29 Issue #5
Jun 19, 2017
Merged text. difficult to read
Declined by admin
The original article is like this.
Template #35 Issue #1
Jun 19, 2017
U use in this case <p>, but the next template far better conveys the essence of the text, since it too stands out from the text. IMHO (Is not critical issue, unlike the previous template)
Declined by admin
Template #29 Issue #6
Jun 19, 2017
https://instantview.telegram.org/contest/bladi.net/template29/issue5/ to admin: "Declined by admin
The original article is like this." The original article not like this. Check next template, they don't merged <p>. He lucky for no critical error in this case.
Dmitry
<li> elements can't have <p> inside so there is only option to @combine(<p>).

Next template extracted all <p> from <li> on their own - IMO it is a valid issue: transformed content hierarchy is different from the original one.
As you said, "He lucky for no critical error in this case".
Declined by admin
Yes, <p> will be stripped from <li> when converting to the IV format. So this is a reasonable way to support the list.
Template #29 Issue #7
Jun 19, 2017
My template supports this page as well, one more page with table that used for design purposes only :)
Dmitry
Duplicate of https://instantview.telegram.org/contest/bladi.net/template29/issue4/

Three-column tables and more complex tables should be tagged as @unsupported.
https://instantview.telegram.org/checklist#6-8-1-tables

This table has no any distinctive classes or markup so there is no a reliable way to determine such a use case except path. I'm not sure but I think supporting such a page (no even article-like) is optional.
Declined by admin
Support for large tables like this is optional.